feat: add pnpm completion script #23
Conversation
commit: |
Aslemammad
left a comment
Aslemammad
left a comment
There was a problem hiding this comment.
Amazing work, this made me way more excited on tab again.
The reason is that we cover all of the ecosystem now, even those who do not use tab for their libraries like regular users can benefit from tab in a tangible way.
|
AmirSa12
force-pushed
the
feat/pnpm-script
branch
from
03e52e5 to
07acf01
Compare
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
this looks really good, i just left a suggestion in your script dunno if we should leave it for later on or it could be manageable to handle it in this same pr, i also would like to add is a bit of docs, like adding a section in the README.md
| case $state in | ||
| filter) | ||
| if [[ -f ./pnpm-workspace.yaml ]] && [[ -x "$pnpm_comp_bin" ]]; then | ||
| _pnpm_tab_debug "Using pnpm-shell-completion for filter packages" | ||
| _values 'filter packages' $(FEATURE=filter $pnpm_comp_bin) | ||
| else | ||
| _pnpm_tab_debug "No workspace or pnpm-shell-completion for filter" | ||
| _message "package filter" | ||
| fi | ||
| ;; | ||
| scripts) | ||
| if [[ -x "$pnpm_comp_bin" ]]; then | ||
| _pnpm_tab_debug "Using pnpm-shell-completion for scripts" | ||
| _values 'scripts' $(FEATURE=scripts TARGET_PKG=$target_pkg ZSH=true $pnpm_comp_bin) \ | ||
| add remove install update publish | ||
| else | ||
| _pnpm_tab_debug "Using basic pnpm commands (no pnpm-shell-completion)" | ||
| _values 'scripts' \ | ||
| 'add:Add a dependency' \ | ||
| 'install:Install dependencies' \ | ||
| 'remove:Remove a dependency' \ | ||
| 'update:Update dependencies' \ | ||
| 'publish:Publish package' \ | ||
| 'run:Run script' | ||
| fi | ||
| ;; |
There was a problem hiding this comment.
i'm just throwing an idea here, but dunno if you explored the possibility of having a caching utility, then use it within the filter completion case to use the cache and finally clean that cache file when the script exits.
* init * prettier * update * cli completions * pnpm install * fix: handle complete command manually * fix: completion-handler __complete => complete * fix: remove examples form package.json * fix: generateCompletionScript function * move the package manager completion logic directly into the parse method * prettier
No description provided.